Remove custom solc in favor of the official 0.8.24 #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lc binaries; remove justfile
hensha256
reviewed
Feb 12, 2024
| 24630 |
hensha256
reviewed
Feb 12, 2024
hensha256
reviewed
Feb 12, 2024
hensha256
requested changes
Feb 12, 2024
hensha256
approved these changes
Feb 12, 2024
zhongeric
pushed a commit
that referenced
this pull request
Feb 12, 2024
* default to evm_version cancun for 0.8.24 for tstore; remove custom solc binaries; remove justfile * snapshots * remove custom solc from CI * remove additional custom solc references * restore formatting
zhongeric
added a commit
that referenced
this pull request
Feb 12, 2024
* don't allow owner to claim fees, update tests * Add revert test for invalid caller * fix: fix directory paths in README (#472) Co-authored-by: saucepoint <[email protected]> * Remove custom solc in favor of the official 0.8.24 (#473) * default to evm_version cancun for 0.8.24 for tstore; remove custom solc binaries; remove justfile * snapshots * remove custom solc from CI * remove additional custom solc references * restore formatting * udpate gas again * gas snaps lol --------- Co-authored-by: Alexander John Lee <[email protected]> Co-authored-by: saucepoint <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
With foundry supporting
evm_version = "cancun"and tstore in 0.8.24, theres no longer a need for the custom solc binaries.The custom binaries and corresponding justfile are now unneeded friction in the hook devex
Description of changes
evm_version = "cancun"to foundry.tomlbin/